Skip to content

[GOOWOO-370] Product Feed showing now synced products#3303

Open
jamesmorrison wants to merge 1 commit intodevelopfrom
feature/GOOWOO-370-product-feed-showing-now-synced-products
Open

[GOOWOO-370] Product Feed showing now synced products#3303
jamesmorrison wants to merge 1 commit intodevelopfrom
feature/GOOWOO-370-product-feed-showing-now-synced-products

Conversation

@jamesmorrison
Copy link
Collaborator

@jamesmorrison jamesmorrison commented Mar 17, 2026

Changes proposed in this Pull Request:

Closes https://linear.app/a8c/issue/GOOWOO-370/product-feed-showing-now-synced-products

Screenshots:

Before:
Screenshot 2026-03-17 at 10 29 14

After:
Screenshot 2026-03-17 at 12 09 48

Detailed test instructions:

  1. Checkout the develop branch
  2. Find or create a product to test (e.g. wp post list --post_type=product --post_status=publish --fields=ID,post_title --format=table)
  3. For the product, set the pull-synced state (replace {ID} with the product ID):
wp post meta update {ID} _wc_gla_visibility sync-and-show
wp post meta update {ID} _wc_gla_sync_status synced
wp post meta update {ID} _wc_gla_synced_at $(date +%s)
wp post meta delete {ID} _wc_gla_mc_status
wp post meta delete {ID} _wc_gla_google_ids

Note: a delete error may show for the last 2 items, it's not a fail, they just didn't exist.

  1. Confirm the state looks correct: wp post meta list {ID} --keys=_wc_gla_visibility,_wc_gla_sync_status,_wc_gla_synced_at,_wc_gla_google_ids,_wc_gla_mc_status --format=table

Expected: only visibility = sync-and-show, sync_status = synced, synced_at = a number. google_ids and mc_status must be absent.

  1. In WP Admin go to Google for WooCommerce → Product Feed.

Wait up to 10 seconds for the status column to populate.
Expected: products show "Not synced"

  1. Check out this feature branch: feature/GOOWOO-370-product-feed-showing-now-synced-products

  2. Reload the product feed page in WP Admin

Wait up to 10 seconds for the status column to populate.

Expected: products show "Pending"

"Pending" is the correct result — the product has been submitted via pull sync but Google has not yet written back a confirmed MC status. In a live connected environment this would progress to "Approved" once the MC status refresh job runs.

Additional details:

Fix - Corrected sync status shown in WP Admin

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 67.1%. Comparing base (e1083e4) to head (baa65a0).

Files with missing lines Patch % Lines
src/DB/ProductFeedQueryHelper.php 50.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             develop   #3303     +/-   ##
===========================================
+ Coverage       66.3%   67.1%   +0.7%     
+ Complexity      5389    5388      -1     
===========================================
  Files            907     526    -381     
  Lines          27939   21483   -6456     
  Branches        1649       0   -1649     
===========================================
- Hits           18534   14409   -4125     
+ Misses          9164    7074   -2090     
+ Partials         241       0    -241     
Flag Coverage Δ
js-unit-tests ?
php-unit-tests 67.1% <88.9%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Product/ProductHelper.php 94.3% <100.0%> (+2.4%) ⬆️
src/Product/ProductRepository.php 85.7% <100.0%> (+0.6%) ⬆️
src/DB/ProductFeedQueryHelper.php 53.3% <50.0%> (-0.6%) ⬇️

... and 381 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant